| Date | Sun, 6 Sep 2020 00:23:23 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH v4 16/31] i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg() |
| |
On Sat, Sep 05, 2020 at 11:41:36PM +0300, Dmitry Osipenko wrote: > The "dma" variable of tegra_i2c_xfer_msg() function doesn't bring much in > regards to readability and generation of the code, hence let's remove it > to clean up code a tad. [...] > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c [...] > + if (i2c_dev->is_curr_dma_xfer) { [...]
In this case I like the previous code better: just because there are less letters to read. :-)
Best Regards, Michał Mirosław
|