| Date | Sun, 6 Sep 2020 00:10:42 +0200 | From | Michał Mirosław <> | Subject | Re: [PATCH v4 11/31] i2c: tegra: Factor out runtime PM and hardware initialization |
| |
On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote: > Factor out runtime PM and hardware initialization into separate function > in order have a cleaner error unwinding in the probe function. [...] > + ret = tegra_i2c_init_runtime_pm_and_hardware(i2c_dev); [...]
This one doesn't improve the code for me. The problems are: 1) putting two unrelated parts in one function, 2) silently reordered initialization.
Best Regards, Michał Mirosław
|