lkml.org 
[lkml]   [2020]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v4 00/31] Improvements for Tegra I2C driver
    Date
    Hello!

    This series performs refactoring of the Tegra I2C driver code and hardens
    the atomic-transfer mode.

    Changelog:

    v4: - Reordered patches in the fixes/features/cleanups order like it was
    suggested by Andy Shevchenko.

    - Now using clk-bulk API, which was suggested by Andy Shevchenko.

    - Reworked "Make tegra_i2c_flush_fifos() usable in atomic transfer"
    patch to use iopoll API, which was suggested by Andy Shevchenko.

    - Separated "Clean up probe function" into several smaller patches.

    - Squashed "Add missing newline before returns" patch into
    "Clean up whitespaces, newlines and indentation".

    - The "Drop '_timeout' from wait/poll function names" is renamed to
    "Rename wait/poll functions".

    - The "Use reset_control_reset()" is changed to not fail tegra_i2c_init(),
    but only emit warning. This should be more friendly behaviour in oppose
    to having a non-bootable machine if reset-control fails.

    - New patches:

    i2c: tegra: Remove error message used for devm_request_irq() failure
    i2c: tegra: Use devm_platform_get_and_ioremap_resource()
    i2c: tegra: Use platform_get_irq()
    i2c: tegra: Use clk-bulk helpers
    i2c: tegra: Remove bogus barrier()
    i2c: tegra: Factor out register polling into separate function
    i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg()
    i2c: tegra: Clean up and improve comments
    i2c: tegra: Rename couple "ret" variables to "err"

    v3: - Optimized "Make tegra_i2c_flush_fifos() usable in atomic transfer"
    patch by pre-checking FIFO state before starting to poll using
    ktime API, which may be expensive under some circumstances.

    - The "Clean up messages in the code" patch now makes all messages
    to use proper capitalization of abbreviations. Thanks to Andy Shevchenko
    and Michał Mirosław for the suggestion.

    - The "Remove unnecessary whitespaces and newlines" patch is transformed
    into "Clean up whitespaces and newlines", it now also adds missing
    newlines and spaces.

    - Reworked the "Clean up probe function" patch in accordance to
    suggestion from Michał Mirosław by factoring out only parts of
    the code that make error unwinding cleaner.

    - Added r-b from Michał Mirosław.

    - Added more patches:

    i2c: tegra: Reorder location of functions in the code
    i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()
    i2c: tegra: Remove "dma" variable
    i2c: tegra: Initialization div-clk rate unconditionally
    i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member

    v2: - Cleaned more messages in the "Clean up messages in the code" patch.

    - The error code of reset_control_reset() is checked now.

    - Added these new patches to clean up couple more things:

    i2c: tegra: Check errors for both positive and negative values
    i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
    i2c: tegra: Remove unnecessary whitespaces and newlines
    i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
    i2c: tegra: Improve driver module description

    Dmitry Osipenko (31):
    i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer
    i2c: tegra: Handle potential error of tegra_i2c_flush_fifos()
    i2c: tegra: Initialization div-clk rate unconditionally
    i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member
    i2c: tegra: Runtime PM always available on Tegra
    i2c: tegra: Remove error message used for devm_request_irq() failure
    i2c: tegra: Use reset_control_reset()
    i2c: tegra: Use devm_platform_get_and_ioremap_resource()
    i2c: tegra: Use platform_get_irq()
    i2c: tegra: Use clk-bulk helpers
    i2c: tegra: Factor out runtime PM and hardware initialization
    i2c: tegra: Move out all device-tree parsing into tegra_i2c_parse_dt()
    i2c: tegra: Clean up probe function
    i2c: tegra: Remove likely/unlikely from the code
    i2c: tegra: Remove bogus barrier()
    i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg()
    i2c: tegra: Improve formatting of function variables
    i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load()
    i2c: tegra: Rename wait/poll functions
    i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear()
    i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg()
    i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()
    i2c: tegra: Factor out register polling into separate function
    i2c: tegra: Reorder location of functions in the code
    i2c: tegra: Check errors for both positive and negative values
    i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg()
    i2c: tegra: Clean up printk messages
    i2c: tegra: Clean up whitespaces, newlines and indentation
    i2c: tegra: Improve driver module description
    i2c: tegra: Clean up and improve comments
    i2c: tegra: Rename couple "ret" variables to "err"

    drivers/i2c/busses/i2c-tegra.c | 1272 +++++++++++++++-----------------
    1 file changed, 612 insertions(+), 660 deletions(-)

    --
    2.27.0

    \
     
     \ /
      Last update: 2020-09-05 22:48    [W:2.357 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site