| Date | Wed, 22 Jul 2020 14:09:30 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 066/133] regmap: debugfs: Dont sleep while atomic for fast_io regmaps |
| |
Hi!
> From: Douglas Anderson <dianders@chromium.org> > > [ Upstream commit 299632e54b2e692d2830af84be51172480dc1e26 ] >
> + err = kstrtobool_from_user(user_buf, count, &new_val); > + /* Ignore malforned data like debugfs_write_file_bool() */
> + err = kstrtobool_from_user(user_buf, count, &new_val); > + /* Ignore malforned data like debugfs_write_file_bool() */
I guess that should be "malformed" in both cases.
Plus it would not be bad to share code between those two functions, as they are pretty much identical...
Best regards, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |