lkml.org 
[lkml]   [2020]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4.19 066/133] regmap: debugfs: Dont sleep while atomic for fast_io regmaps
Hi!

> From: Douglas Anderson <dianders@chromium.org>
>
> [ Upstream commit 299632e54b2e692d2830af84be51172480dc1e26 ]
>

> + err = kstrtobool_from_user(user_buf, count, &new_val);
> + /* Ignore malforned data like debugfs_write_file_bool() */

> + err = kstrtobool_from_user(user_buf, count, &new_val);
> + /* Ignore malforned data like debugfs_write_file_bool() */

I guess that should be "malformed" in both cases.

Plus it would not be bad to share code between those two functions, as
they are pretty much identical...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-22 14:10    [W:0.692 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site