lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 086/133] ALSA: line6: Sync the pending work cancel at disconnection
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 68359a1ad8447c99732ebeab8c169bfed543667a upstream.

    Recently syzkaller reported a UAF in LINE6 driver, and it's likely
    because we call cancel_delayed_work() at the disconnect callback
    instead of cancel_delayed_work_sync(). Let's use the correct one
    instead.

    Reported-by: syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com
    Suggested-by: Alan Stern <stern@rowland.harvard.edu>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/s5hlfjr4gio.wl-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/line6/driver.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/usb/line6/driver.c
    +++ b/sound/usb/line6/driver.c
    @@ -835,7 +835,7 @@ void line6_disconnect(struct usb_interfa
    if (WARN_ON(usbdev != line6->usbdev))
    return;

    - cancel_delayed_work(&line6->startup_work);
    + cancel_delayed_work_sync(&line6->startup_work);

    if (line6->urb_listen != NULL)
    line6_stop_listen(line6);

    \
     
     \ /
      Last update: 2020-07-20 19:10    [W:2.822 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site