lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 033/133] iio: pressure: zpa2326: handle pm_runtime_get_sync failure
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    commit d88de040e1df38414fc1e4380be9d0e997ab4d58 upstream.

    Calling pm_runtime_get_sync increments the counter even in case of
    failure, causing incorrect ref count. Call pm_runtime_put if
    pm_runtime_get_sync fails.

    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Fixes: 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support")
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/pressure/zpa2326.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/iio/pressure/zpa2326.c
    +++ b/drivers/iio/pressure/zpa2326.c
    @@ -672,8 +672,10 @@ static int zpa2326_resume(const struct i
    int err;

    err = pm_runtime_get_sync(indio_dev->dev.parent);
    - if (err < 0)
    + if (err < 0) {
    + pm_runtime_put(indio_dev->dev.parent);
    return err;
    + }

    if (err > 0) {
    /*

    \
     
     \ /
      Last update: 2020-07-20 17:52    [W:3.006 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site