Messages in this thread | | | Date | Mon, 20 Jul 2020 16:04:10 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v15 2/9] nvme: Create helper function to obtain command effects |
| |
On Thu, Jul 16, 2020 at 02:33:12PM -0600, Logan Gunthorpe wrote: > Separate the code to obtain command effects from the code > to start a passthru request and open code nvme_known_admin_effects() > in the new helper. > > The new helper function will be necessary for nvmet passthru > code to determine if we need to change out of interrupt context > to handle the effects.
I actually found the nvme_known_admin_effects pretty nice, as the function name documents why it is there. The rest looks fine to me.
| |