lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v15 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper
On Thu, Jul 16, 2020 at 02:33:13PM -0600, Logan Gunthorpe wrote:
> Introduce a new nvme_execute_passthru_rq() helper which calls
> nvme_passthru_[start|end]() around blk_execute_rq(). This ensures
> all passthru calls (including nvme_submit_io()) will be wrapped
> appropriately.
>
> nvme_execute_passthru_rq() will also be useful for the nvmet passthru
> code.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

although maybe you could have moved the code you changed in the
last patch up already to not just move it after changing it in the
last one.

\
 
 \ /
  Last update: 2020-07-20 16:07    [W:0.123 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site