Messages in this thread | | | Date | Mon, 20 Jul 2020 16:06:01 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v15 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper |
| |
On Thu, Jul 16, 2020 at 02:33:13PM -0600, Logan Gunthorpe wrote: > Introduce a new nvme_execute_passthru_rq() helper which calls > nvme_passthru_[start|end]() around blk_execute_rq(). This ensures > all passthru calls (including nvme_submit_io()) will be wrapped > appropriately. > > nvme_execute_passthru_rq() will also be useful for the nvmet passthru > code. > > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
although maybe you could have moved the code you changed in the last patch up already to not just move it after changing it in the last one.
| |