Messages in this thread | | | From | Anup Patel <> | Date | Wed, 1 Jul 2020 15:13:31 +0530 | Subject | Re: [PATCH v4 12/14] irqchip/riscv-intc: Fix potential resource leak |
| |
On Wed, Jul 1, 2020 at 7:47 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote: > > In the function riscv_intc_init(), system resource "intc_domain" > was not released in the error case, fix it. > > Fixes: 6b7ce8927b5a ("irqchip: RISC-V per-HART local interrupt controller driver") > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > drivers/irqchip/irq-riscv-intc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c > index a6f97fa..8d6286c 100644 > --- a/drivers/irqchip/irq-riscv-intc.c > +++ b/drivers/irqchip/irq-riscv-intc.c > @@ -122,6 +122,7 @@ static int __init riscv_intc_init(struct device_node *node, > rc = set_handle_irq(&riscv_intc_irq); > if (rc) { > pr_err("failed to set irq handler\n"); > + irq_domain_remove(intc_domain); > return rc; > } > > -- > 2.1.0 >
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards, Anup
| |