Messages in this thread | | | Subject | Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak | From | Tiezhu Yang <> | Date | Wed, 1 Jul 2020 17:58:06 +0800 |
| |
On 07/01/2020 05:42 PM, Markus Elfring wrote: >> In the function xilinx_intc_of_init(), system resource "irqc->root_domain" >> was not released in the error case. Thus add jump target for the completion >> of the desired exception handling. > Another small wording adjustment: > … Thus add a jump target …
OK
> > > … >> +++ b/drivers/irqchip/irq-xilinx-intc.c > … >> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, >> >> return 0; >> >> +error_domain_remove: >> + irq_domain_remove(irqc->root_domain); >> error: >> iounmap(irqc->base); > … > > Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Thank you, I will use "err_domain_remove" and "err_iounmap" to keep consistence with other patches.
> > Regards, > Markus
| |