Messages in this thread | | | Subject | Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak | From | Markus Elfring <> | Date | Wed, 1 Jul 2020 11:42:47 +0200 |
| |
> In the function xilinx_intc_of_init(), system resource "irqc->root_domain" > was not released in the error case. Thus add jump target for the completion > of the desired exception handling.
Another small wording adjustment: … Thus add a jump target …
… > +++ b/drivers/irqchip/irq-xilinx-intc.c … > @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, > > return 0; > > +error_domain_remove: > + irq_domain_remove(irqc->root_domain); > error: > iounmap(irqc->base); …
Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Regards, Markus
| |