Messages in this thread | | | From | Kaaira Gupta <> | Subject | [PATCH v5 0/3] | Date | Wed, 24 Jun 2020 19:13:51 +0530 |
| |
Changes since v4: - Add another patch which changes char argument to const char in function tpg_gen_text() - Return const char * from function tpg_g_color_order() in patch 2 In 3rd patch: - Check font in probe() instead of s_stream() - Use dev_err instead of pr_err - Fix errors in commit message. - Base VIMC_CID_SHOW_INFO on VIVID_CID_OSD_TEXT_MODE
Changes since v3: In 1st patch: -Improved formatting of returned string.
In 2nd patch: - Add CID prefix in control name and change it to a more generic name. - Rename bool variable to a generic name. - Disable text rendering instead of stopping stream if no font found. - Display more info like VIVID in VIMC.
Changes since v2: In 1st patch: - Create a 'define' to prevent repetition of the common color sequence string. - Use 'fallthrough' on case statement to prevent repetition of code.
Changes since v1: - Divided the patch into two patches. - Returned NULL for patterns whose color order cannot be defined. (Reported-by: kernel test robot <lkp@intel.com>) - Made separate switch cases for separate test patterns (Reported-by: kernel test robot <lkp@intel.com>) - Renamed variables from camelcase to use '_' - prefixed 'media' to the patches.
Kaaira Gupta (3): media: tpg: change char argument to const char media: tpg: Add function to return colors' order of test image media: vimc: Add a control to display info on test image
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 39 ++++++++++--- drivers/media/test-drivers/vimc/Kconfig | 2 + drivers/media/test-drivers/vimc/vimc-common.h | 1 + drivers/media/test-drivers/vimc/vimc-core.c | 10 ++++ drivers/media/test-drivers/vimc/vimc-sensor.c | 57 +++++++++++++++++++ include/media/tpg/v4l2-tpg.h | 3 +- 6 files changed, 104 insertions(+), 8 deletions(-)
-- 2.17.1
| |