Messages in this thread Patch in this message | | | Date | Sat, 16 May 2020 00:09:19 -0400 | From | Rafael Aquini <> | Subject | Re: [PATCH v2 07/15] cxgb4: use new module_firmware_crashed() |
| |
On Fri, May 15, 2020 at 09:28:38PM +0000, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Vishal Kulkarni <vishal@chelsio.com> > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > index a70018f067aa..c67fc86c0e42 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > @@ -3646,6 +3646,7 @@ void t4_fatal_err(struct adapter *adap) > * could be exposed to the adapter. RDMA MWs for example... > */ > t4_shutdown_adapter(adap); > + module_firmware_crashed(); > for_each_port(adap, port) { > struct net_device *dev = adap->port[port]; > > -- > 2.26.2 > Acked-by: Rafael Aquini <aquini@redhat.com>
| |