lkml.org 
[lkml]   [2020]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v2 04/15] bnxt: use new module_firmware_crashed()
    On Fri, May 15, 2020 at 09:28:35PM +0000, Luis Chamberlain wrote:
    > This makes use of the new module_firmware_crashed() to help
    > annotate when firmware for device drivers crash. When firmware
    > crashes devices can sometimes become unresponsive, and recovery
    > sometimes requires a driver unload / reload and in the worst cases
    > a reboot.
    >
    > Using a taint flag allows us to annotate when this happens clearly.
    >
    > Cc: Michael Chan <michael.chan@broadcom.com>
    > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
    > ---
    > drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    > index dd0c3f227009..5ba1bd0734e9 100644
    > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
    > @@ -3503,6 +3503,7 @@ static int bnxt_get_dump_data(struct net_device *dev, struct ethtool_dump *dump,
    >
    > dump->flag = bp->dump_flag;
    > if (dump->flag == BNXT_DUMP_CRASH) {
    > + module_firmware_crashed();
    > #ifdef CONFIG_TEE_BNXT_FW
    > return tee_bnxt_copy_coredump(buf, 0, dump->len);
    > #endif
    > --
    > 2.26.2
    >
    Acked-by: Rafael Aquini <aquini@redhat.com>

    \
     
     \ /
      Last update: 2020-05-16 06:06    [W:2.562 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site