lkml.org 
[lkml]   [2020]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 06/15] liquidio: use new module_firmware_crashed()
On Fri, May 15, 2020 at 09:28:37PM +0000, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: Derek Chickles <dchickles@marvell.com>
> Cc: Satanand Burla <sburla@marvell.com>
> Cc: Felix Manlunas <fmanlunas@marvell.com>
> Reviewed-by: Derek Chickles <dchickles@marvell.com>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> index 66d31c018c7e..f18085262982 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param)
> continue;
>
> WRITE_ONCE(oct->cores_crashed, true);
> + module_firmware_crashed();
> other_oct = get_other_octeon_device(oct);
> if (other_oct)
> WRITE_ONCE(other_oct->cores_crashed, true);
> --
> 2.26.2
>
Acked-by: Rafael Aquini <aquini@redhat.com>

\
 
 \ /
  Last update: 2020-05-16 06:08    [W:0.139 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site