| Date | Wed, 13 May 2020 19:42:17 -0400 (EDT) | From | Mathieu Desnoyers <> | Subject | Re: [patch V4 part 1 29/36] x86/mce: Send #MC singal from task work |
| |
----- On May 5, 2020, at 9:16 AM, Thomas Gleixner tglx@linutronix.de wrote:
> From: Peter Zijlstra <peterz@infradead.org> >
Patch title: singal -> signal.
> Convert #MC over to using task_work_add(); it will run the same code > slightly later, on the return to user path of the same exception.
So I suspect that switching the order between tracehook_notify_resume() (which ends up calling task_work_run()) and do_signal() done by an earlier patch in this series intends to ensure the information about the instruction pointer causing the #MC is not overwritten by do_signal() (but I'm just guessing).
If it's the case, I think it should be clearly stated as the intent of the earlier patch.
Thanks,
Mathieu
-- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
|