lkml.org 
[lkml]   [2020]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi()
    Date
    Alexandre Chartre <alexandre.chartre@oracle.com> writes:
    > On 5/5/20 3:16 PM, Thomas Gleixner wrote:
    >> @@ -10009,12 +10009,11 @@ static void kick_ilb(unsigned int flags)
    >> return;
    >>
    >> /*
    >> - * Use smp_send_reschedule() instead of resched_cpu().
    >> - * This way we generate a sched IPI on the target CPU which
    >> + * This way we generate an IPI on the target CPU which
    >> * is idle. And the softirq performing nohz idle load balance
    >> * will be run before returning from the IPI.
    >> */
    >> - smp_send_reschedule(ilb_cpu);
    >> + smp_call_function_single_async(ilb_cpu, &cpu_rq(ilb_cpu)->wake_csd);
    >
    > This should be nohz_csd instead of wake_csd, no? I.e.:
    >
    > smp_call_function_single_async(ilb_cpu, &cpu_rq(ilb_cpu)->nohz_csd);

    Good catch!

    \
     
     \ /
      Last update: 2020-05-06 17:04    [W:4.398 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site