Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch V4 part 1 03/36] sched: Clean up scheduler_ipi() | Date | Wed, 06 May 2020 17:03:17 +0200 |
| |
Alexandre Chartre <alexandre.chartre@oracle.com> writes: > On 5/5/20 3:16 PM, Thomas Gleixner wrote: >> @@ -10009,12 +10009,11 @@ static void kick_ilb(unsigned int flags) >> return; >> >> /* >> - * Use smp_send_reschedule() instead of resched_cpu(). >> - * This way we generate a sched IPI on the target CPU which >> + * This way we generate an IPI on the target CPU which >> * is idle. And the softirq performing nohz idle load balance >> * will be run before returning from the IPI. >> */ >> - smp_send_reschedule(ilb_cpu); >> + smp_call_function_single_async(ilb_cpu, &cpu_rq(ilb_cpu)->wake_csd); > > This should be nohz_csd instead of wake_csd, no? I.e.: > > smp_call_function_single_async(ilb_cpu, &cpu_rq(ilb_cpu)->nohz_csd);
Good catch!
| |