lkml.org 
[lkml]   [2020]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] seqlock: Use while instead of if+goto in __read_seqcount_begin
Date
The creators of the C language gave us the while keyword. Let's use
that instead of synthesizing it from if+goto.

Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
include/linux/seqlock.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 8b97204f35a77..7bdea019814ce 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -125,12 +125,8 @@ static inline unsigned __read_seqcount_begin(const seqcount_t *s)
{
unsigned ret;

-repeat:
- ret = READ_ONCE(s->sequence);
- if (unlikely(ret & 1)) {
+ while (unlikely((ret = READ_ONCE(s->sequence)) & 1))
cpu_relax();
- goto repeat;
- }
kcsan_atomic_next(KCSAN_SEQLOCK_REGION_MAX);
return ret;
}
--
2.11.0
\
 
 \ /
  Last update: 2020-04-09 15:47    [W:1.267 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site