lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [External] Re: [PATCH] seqlock: Use while instead of if+goto in __read_seqcount_begin
On Fri, Apr 10, 2020 at 7:57 PM Will Deacon <will@kernel.org> wrote:
>
> On Thu, Apr 09, 2020 at 09:45:58PM +0800, Muchun Song wrote:
> > The creators of the C language gave us the while keyword. Let's use
> > that instead of synthesizing it from if+goto.
> >
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > ---
> > include/linux/seqlock.h | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 8b97204f35a77..7bdea019814ce 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -125,12 +125,8 @@ static inline unsigned __read_seqcount_begin(const seqcount_t *s)
> > {
> > unsigned ret;
> >
> > -repeat:
> > - ret = READ_ONCE(s->sequence);
> > - if (unlikely(ret & 1)) {
> > + while (unlikely((ret = READ_ONCE(s->sequence)) & 1))
> > cpu_relax();
> > - goto repeat;
> > - }
> > kcsan_atomic_next(KCSAN_SEQLOCK_REGION_MAX);
> > return ret;
>
> Patch looks fine to me, but I'll leave it to Peter as I don't have a
> preference either way.
>

This patch can make the code look simple and easy to read.
What is your opinion, Peter? Thanks.


--
Yours,
Muchun

\
 
 \ /
  Last update: 2020-04-14 11:00    [W:0.086 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site