Messages in this thread Patch in this message | | | From | Maciej Żenczykowski <> | Subject | [PATCH] [RFC] net: bpf: make __bpf_skb_max_len(skb) an skb-independent constant | Date | Mon, 20 Apr 2020 16:14:27 -0700 |
| |
From: Maciej Żenczykowski <maze@google.com>
This function is used from: bpf_skb_adjust_room __bpf_skb_change_tail __bpf_skb_change_head
but in the case of forwarding we're likely calling these functions during receive processing on ingress and bpf_redirect()'ing at a later point in time to egress on another interface, thus these mtu checks are for the wrong device.
This is particularly problematic if we're receiving on an L3 1500 mtu cellular interface, trying to add an L2 header and forwarding to an L3 mtu 1500 mtu wifi/ethernet device. The mtu check prevents us from adding the ethernet header prior to forwarding the packet. After the packet has already been redirected, we'd need to add an additional 2nd ebpf program on the target device's egress tc hook, but then we'd also see non-redirected traffic and have no easy way to tell apart normal egress with ethernet header packets from forwarded ethernet headerless packets.
Signed-off-by: Maciej Żenczykowski <maze@google.com> --- net/core/filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c index ec567d1e6fb9..1e119a47f9fe 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -3159,8 +3159,7 @@ static int bpf_skb_net_shrink(struct sk_buff *skb, u32 off, u32 len_diff, static u32 __bpf_skb_max_len(const struct sk_buff *skb) { - return skb->dev ? skb->dev->mtu + skb->dev->hard_header_len : - SKB_MAX_ALLOC; + return SKB_MAX_ALLOC; } BPF_CALL_4(bpf_skb_adjust_room, struct sk_buff *, skb, s32, len_diff, -- 2.26.1.301.g55bc3eb7cb9-goog
| |