| Date | Thu, 12 Nov 2020 21:01:41 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 105/191] memory: emif: Remove bogus debugfs error handling |
| |
Hi!
> From: Dan Carpenter <dan.carpenter@oracle.com> > > [ Upstream commit fd22781648080cc400772b3c68aa6b059d2d5420 ] > > Callers are generally not supposed to check the return values from > debugfs functions. Debugfs functions never return NULL so this error > handling will never trigger. (Historically debugfs functions used to > return a mix of NULL and error pointers but it was eventually deemed too > complicated for something which wasn't intended to be used in normal > situations). > > Delete all the error handling.
This is wrong for 4.19.
Memory functions still return NULL here.
Best regards, Pavel
-- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] |