lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 174/191] ext4: fix error handling code in add_new_gdb
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    commit c9e87161cc621cbdcfc472fa0b2d81c63780c8f5 upstream.

    When ext4_journal_get_write_access() fails, we should
    terminate the execution flow and release n_group_desc,
    iloc.bh, dind and gdb_bh.

    Cc: stable@kernel.org
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Reviewed-by: Andreas Dilger <adilger@dilger.ca>
    Link: https://lore.kernel.org/r/20200829025403.3139-1-dinghao.liu@zju.edu.cn
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/resize.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -861,8 +861,10 @@ static int add_new_gdb(handle_t *handle,

    BUFFER_TRACE(dind, "get_write_access");
    err = ext4_journal_get_write_access(handle, dind);
    - if (unlikely(err))
    + if (unlikely(err)) {
    ext4_std_error(sb, err);
    + goto errout;
    + }

    /* ext4_reserve_inode_write() gets a reference on the iloc */
    err = ext4_reserve_inode_write(handle, inode, &iloc);

    \
     
     \ /
      Last update: 2020-11-03 22:20    [W:4.026 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site