lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 016/191] r8169: fix issue with forced threading in combination with shared interrupts
    Date
    From: Heiner Kallweit <hkallweit1@gmail.com>

    [ Upstream commit 2734a24e6e5d18522fbf599135c59b82ec9b2c9e ]

    As reported by Serge flag IRQF_NO_THREAD causes an error if the
    interrupt is actually shared and the other driver(s) don't have this
    flag set. This situation can occur if a PCI(e) legacy interrupt is
    used in combination with forced threading.
    There's no good way to deal with this properly, therefore we have to
    remove flag IRQF_NO_THREAD. For fixing the original forced threading
    issue switch to napi_schedule().

    Fixes: 424a646e072a ("r8169: fix operation under forced interrupt threading")
    Link: https://www.spinics.net/lists/netdev/msg694960.html
    Reported-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
    Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
    Tested-by: Serge Belyshev <belyshev@depni.sinp.msu.ru>
    Link: https://lore.kernel.org/r/b5b53bfe-35ac-3768-85bf-74d1290cf394@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/realtek/r8169.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/realtek/r8169.c
    +++ b/drivers/net/ethernet/realtek/r8169.c
    @@ -6630,7 +6630,7 @@ static irqreturn_t rtl8169_interrupt(int
    return IRQ_NONE;

    rtl_irq_disable(tp);
    - napi_schedule_irqoff(&tp->napi);
    + napi_schedule(&tp->napi);

    return IRQ_HANDLED;
    }
    @@ -6886,7 +6886,7 @@ static int rtl_open(struct net_device *d
    rtl_request_firmware(tp);

    retval = request_irq(pci_irq_vector(pdev, 0), rtl8169_interrupt,
    - IRQF_NO_THREAD | IRQF_SHARED, dev->name, tp);
    + IRQF_SHARED, dev->name, tp);
    if (retval < 0)
    goto err_release_fw_2;


    \
     
     \ /
      Last update: 2020-11-03 22:27    [W:4.575 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site