Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | [PATCH v2 0/4] cpufreq: intel_pstate: Avoid missing HWP max limit updates with powersave governor | Date | Fri, 23 Oct 2020 17:21:50 +0200 |
| |
Hi All,
There is a problem in intel_pstate that if it works in the passive mode with HWP enabled, changing the policy max frequency may not cause the HWP max limit to be updated accordingly which is quite confusing and may be incorrect.
That happens because of two checks, one in the cpufreq core and one in the driver itself, that are there to avoid unnecessary HW/FW updates when the current frequency doesn't change. Of course, that is the case when the policy max limit changes under the "powersave" governor (which sets the current frequency to the policy min limit) and in that particular case, the checks turn out to be harmful.
There is also an analogous problem in the schedutil governor that prevents driver callbacks from being invoked if the target frequency doesn't change and which also affects intel_pstate in the passive mode with HWP enabled (see the changelog of patch [4/4]).
The v2 addresses some review comments from Viresh and adds patches [3-4/4] to address the schedutil issue.
The cleanup posted as the [2/2] previously will be applied independently and it is not included in the v2.
Thanks!
| |