Messages in this thread | | | From | Markus Elfring <> | Subject | Coccinelle: pci_free_consistent: Checking when constraints | Date | Sun, 8 Sep 2019 10:10:13 +0200 |
| |
Hello,
I have taken another look at a known script for the semantic patch language. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/pci_free_consistent.cocci?id=950b07c14e8c59444e2359f15fd70ed5112e11a0#n2
The following SmPL code is used there so far.
… ... when != pci_free_consistent(x,y,id,z) when != if (id) { ... pci_free_consistent(x,y,id,z) ... } when != if (y) { ... pci_free_consistent(x,y,id,z) ... } …
It is specified that a specific function call should be excluded in a source code search. I do not see a need to repeat the specification twice that such a call could eventually happen also within a branch of another if statement. How do you think about to omit possibly redundant SmPL code at this place?
Regards, Markus
| |