Messages in this thread | | | Date | Thu, 15 Aug 2019 11:23:47 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 18/22] watchdog: ziirave_wdt: Fix RESET_PROCESSOR payload |
| |
On Mon, Aug 12, 2019 at 01:09:02PM -0700, Andrey Smirnov wrote: > Bootloader firmware expects the following traffic for > RESET_PROCESSOR: > > S Addr Wr [A] 0x0b [A] 0x01 [A] P > > using ziirave_firm_write_byte() will result in > > S Addr Wr [A] 0x0b [A] 0x01 [A] 0x01 [A] P > > which happens to work because firmware will ignore any extra bytes and > expected magic value matches byte count sent by > i2c_smbus_write_block_data(). Fix this by converting the code to use > i2c_smbus_write_byte_data() instead. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Rick Ramstetter <rick@anteaterllc.com> > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
| |