| Date | Thu, 15 Aug 2019 11:14:53 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 07/22] watchdog: ziirave_wdt: Check packet length only once |
| |
On Mon, Aug 12, 2019 at 01:08:51PM -0700, Andrey Smirnov wrote: > We don't need to check for packet length more than once, so drop the > extra check in ziirave_firm_upload(). While at it move the check at > the very start of __ziirave_firm_write_pkt(), as to not waste any time > preparing a packet we'll never use. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Rick Ramstetter <rick@anteaterllc.com> > Cc: linux-watchdog@vger.kernel.org > Cc: linux-kernel@vger.kernel.org
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
|