lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 08/22] watchdog: ziirave_wdt: Skip zeros when calculating checksum
    Date
    Zeros don't contribute anything to checksum value, so we can skip
    unused portion of the packet when calculating its checksum.

    Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
    Cc: Chris Healy <cphealy@gmail.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: Rick Ramstetter <rick@anteaterllc.com>
    Cc: linux-watchdog@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/watchdog/ziirave_wdt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
    index 9d9c669b8b47..19da0910c2d1 100644
    --- a/drivers/watchdog/ziirave_wdt.c
    +++ b/drivers/watchdog/ziirave_wdt.c
    @@ -271,7 +271,7 @@ static int __ziirave_firm_write_pkt(struct watchdog_device *wdd,
    memcpy(packet + 3, data, len);

    /* Packet checksum */
    - for (i = 0; i < ZIIRAVE_FIRM_PKT_TOTAL_SIZE - 1; i++)
    + for (i = 0; i < len + 3; i++)
    checksum += packet[i];
    packet[ZIIRAVE_FIRM_PKT_TOTAL_SIZE - 1] = checksum;

    --
    2.21.0
    \
     
     \ /
      Last update: 2019-08-12 22:10    [W:4.039 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site