Messages in this thread | | | Date | Sun, 28 Jul 2019 06:58:26 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] Makefile: Globally enable fall-through warning |
| |
On Thu, Jun 06, 2019 at 07:46:17PM -0500, Gustavo A. R. Silva wrote: > Now that all the fall-through warnings have been addressed in the > kernel, enable the fall-through warning globally. >
Not really "all".
powerpc:85xx/sbc8548_defconfig:
arch/powerpc/kernel/align.c: In function ‘emulate_spe’: arch/powerpc/kernel/align.c:178:8: error: this statement may fall through
Plus many more similar errors in the same file.
All sh builds:
arch/sh/kernel/disassemble.c: In function 'print_sh_insn': arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through
Again, this is seen in several places.
mips:cavium_octeon_defconfig:
arch/mips/cavium-octeon/octeon-usb.c: In function 'dwc3_octeon_clocks_start': include/linux/device.h:1499:2: error: this statement may fall through
None of those are from recent changes. And this is just from my small subset of test builds.
Guenter
| |