Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 29 Jul 2019 10:22:29 +0200 | Subject | Re: [PATCH] Makefile: Globally enable fall-through warning |
| |
Hi Gustavo,
On Sun, Jul 28, 2019 at 6:44 PM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > On 7/28/19 8:58 AM, Guenter Roeck wrote: > > On Thu, Jun 06, 2019 at 07:46:17PM -0500, Gustavo A. R. Silva wrote: > >> Now that all the fall-through warnings have been addressed in the > >> kernel, enable the fall-through warning globally. > >> > > > > Not really "all". > > > > powerpc:85xx/sbc8548_defconfig: > > > > arch/powerpc/kernel/align.c: In function ‘emulate_spe’: > > arch/powerpc/kernel/align.c:178:8: error: this statement may fall through > > > > Plus many more similar errors in the same file. > > > > All sh builds: > > > > arch/sh/kernel/disassemble.c: In function 'print_sh_insn': > > arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through > > > > Again, this is seen in several places. > > > > mips:cavium_octeon_defconfig: > > > > arch/mips/cavium-octeon/octeon-usb.c: In function 'dwc3_octeon_clocks_start': > > include/linux/device.h:1499:2: error: this statement may fall through > > > > None of those are from recent changes. And this is just from my small > > subset of test builds. > > > > Thank you for letting me know about this. I don't have access to build > infrastructure like yours. > > My build infrastructure is similar to that of Linus. > > But if you send me all of those I can create a patch and send it back > to you to make sure what you see is addressed. If we can coordinate for > this it'd be great for everybody. :) >
More to be found in https://lore.kernel.org/lkml/20190729081727.6094-1-geert@linux-m68k.org/
and I saw the following in my local builds (not detected above due to kisskb using an older compiler for m68k builds):
arch/m68k/include/asm/amigahw.h: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 42:50 drivers/block/ataflop.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 1728:3 drivers/net/arcnet/com20020-isa.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 205:13, 203:10, 209:7, 201:11, 207:8 drivers/scsi/sun3_scsi.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 399:9, 403:9 sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 1449:24
Thanks for fixing ;-)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |