Messages in this thread | | | Subject | Re: [PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS | From | Joe Perches <> | Date | Wed, 08 May 2019 07:19:29 -0700 |
| |
On Wed, 2019-05-08 at 14:27 +0200, Antonio Borneo wrote: > The warning LINE_CONTINUATIONS does not offer a --fix. > > Add the trivial --fix. > In case of consecutive lines with the same issue, this will > fix only the first line. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5207,8 +5207,11 @@ sub process { > $line !~ /^\+\s*\#.*\\$/ && # preprocessor > $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ && # asm > $line =~ /^\+.*\\$/) { > - WARN("LINE_CONTINUATIONS", > - "Avoid unnecessary line continuations\n" . $herecurr); > + if (WARN("LINE_CONTINUATIONS", > + "Avoid unnecessary line continuations\n" . $herecurr) &&
I prefer to not apply this.
Problem here is that these should generally be fixed by hand as the automated fix isn't very good style either.
> + $fix) { > + $fixed[$fixlinenr] =~ s/\s*\\$//; > + } > } > } >
| |