Messages in this thread | | | Subject | Re: [PATCH 4/4] checkpatch: replace magic value for TAB size | From | Joe Perches <> | Date | Wed, 08 May 2019 10:02:42 -0700 |
| |
On Wed, 2019-05-08 at 17:32 +0200, Antonio Borneo wrote: > On Wed, May 8, 2019 at 4:52 PM Joe Perches <joe@perches.com> wrote: > ... > > > In these cases the script will be probably modified and adapted, > > > so there is no need (at least for the moment) to expose this > > > setting on the script's command line. > > > > Disagree. Probably getter to add a --tabsize=<foo> option now. > > Ok, will send a V2 including the command line option. > Exposing TAB size, makes the option name relevant; should I keep > "--tabsize" or is "--tab-stop" more appropriate?
--tabsize is probably more appropriate as tab stops are not always a multiple of a single number.
Unless you really want to get funky and support something like --tab-stops=7,13,17,...
I don't suggest that.
| |