Messages in this thread | | | Date | Wed, 8 May 2019 11:48:31 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 7/7] cpumask: don't calculate length of the input string |
| |
On Tue, Apr 30, 2019 at 06:06:36PM -0700, Yury Norov wrote: > New design of inner bitmap_parse() allows to avoid > calculating the size of a null-terminated string. >
FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yury Norov <ynorov@marvell.com> > --- > include/linux/cpumask.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h > index 21755471b1c3..d55d015edc58 100644 > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -633,9 +633,7 @@ static inline int cpumask_parselist_user(const char __user *buf, int len, > */ > static inline int cpumask_parse(const char *buf, struct cpumask *dstp) > { > - unsigned int len = strchrnul(buf, '\n') - buf; > - > - return bitmap_parse(buf, len, cpumask_bits(dstp), nr_cpumask_bits); > + return bitmap_parse(buf, UINT_MAX, cpumask_bits(dstp), nr_cpumask_bits); > } > > /** > -- > 2.17.1 >
-- With Best Regards, Andy Shevchenko
| |