Messages in this thread | | | Date | Wed, 8 May 2019 11:47:12 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 2/7] bitops: more BITS_TO_* macros |
| |
On Tue, Apr 30, 2019 at 06:06:31PM -0700, Yury Norov wrote: > Introduce BITS_TO_U64, BITS_TO_U32 and BITS_TO_BYTES as they are handy > in the following patches (BITS_TO_U32 specifically). Reimplement tools/ > version of the macros according to the kernel implementation. > > Also fix indentation for BITS_PER_TYPE definition. >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yury Norov <ynorov@marvell.com> > --- > include/linux/bitops.h | 5 ++++- > tools/include/linux/bitops.h | 9 +++++---- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/include/linux/bitops.h b/include/linux/bitops.h > index cf074bce3eb3..e61c4e614264 100644 > --- a/include/linux/bitops.h > +++ b/include/linux/bitops.h > @@ -4,8 +4,11 @@ > #include <asm/types.h> > #include <linux/bits.h> > > -#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) > +#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) > #define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(long)) > +#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u64)) > +#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u32)) > +#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(char)) > > extern unsigned int __sw_hweight8(unsigned int w); > extern unsigned int __sw_hweight16(unsigned int w); > diff --git a/tools/include/linux/bitops.h b/tools/include/linux/bitops.h > index 0b0ef3abc966..a8ba37a50d08 100644 > --- a/tools/include/linux/bitops.h > +++ b/tools/include/linux/bitops.h > @@ -13,10 +13,11 @@ > #include <linux/bits.h> > #include <linux/compiler.h> > > -#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long)) > -#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u64)) > -#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32)) > -#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_BYTE) > +#define BITS_PER_TYPE(type) (sizeof(type) * BITS_PER_BYTE) > +#define BITS_TO_LONGS(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(long)) > +#define BITS_TO_U64(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u64)) > +#define BITS_TO_U32(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(u32)) > +#define BITS_TO_BYTES(nr) DIV_ROUND_UP(nr, BITS_PER_TYPE(char)) > > extern unsigned int __sw_hweight8(unsigned int w); > extern unsigned int __sw_hweight16(unsigned int w); > -- > 2.17.1 >
-- With Best Regards, Andy Shevchenko
| |