Messages in this thread | | | Date | Wed, 8 May 2019 11:46:32 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 5/7] lib: rework bitmap_parse() |
| |
On Tue, Apr 30, 2019 at 06:06:34PM -0700, Yury Norov wrote: > bitmap_parse() is ineffective and full of opaque variables and opencoded > parts. It leads to hard understanding and usage of it. This rework > includes: > - remove bitmap_shift_left() call from the cycle. Now it makes the > complexity of the algorithm as O(nbits^2). In the suggested approach > the input string is parsed in reverse direction, so no shifts needed; > - relax requirement on a single comma and no white spaces between chunks. > It is considered useful in scripting, and it aligns with > bitmap_parselist(); > - split bitmap_parse() to small readable helpers; > - make an explicit calculation of the end of input line at the > beginning, so users of the bitmap_parse() won't bother doing this.
> +static inline bool in_str(const char *start, const char *ptr) > +{ > + return start <= ptr; > +} > +
The explicit use of the conditional is better.
-- With Best Regards, Andy Shevchenko
| |