Messages in this thread | | | Subject | Re: [PATCH] Smack: Restore the smackfsdef mount option | From | Casey Schaufler <> | Date | Tue, 28 May 2019 09:41:10 -0700 |
| |
On 5/28/2019 9:22 AM, David Howells wrote: > Casey Schaufler <casey@schaufler-ca.com> wrote: > >>> Also, should all of these be prefixed with "smack"? So: >>> >>> fsparam_string("smackfsdef", Opt_fsdefault), >>> fsparam_string("smackfsfloor", Opt_fsfloor), >>> fsparam_string("smackfshat", Opt_fshat), >> No. smack_fs_parameters takes care of that. > It does? *Blink*.
Well, something does. I can't say that I 100% understand all of how the new mount code handles the mount options. Y'all made sweeping changes, and the code works the way it used to except for the awkward change from smackfsdef to smackfsdefault. It took no small amount of head scratching and experimentation to convince myself that the fix I proposed was correct.
> > smack_fs_parameters.name is just for decorating messages, if that's what > you're looking at. > > David
| |