lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Smack: Restore the smackfsdef mount option
From
Date
On 5/28/2019 5:23 AM, David Howells wrote:
> Casey Schaufler <casey@schaufler-ca.com> wrote:
>
>> The change was made in commit c3300aaf95fb4 from Al Viro.
> This should be in a "Fixes:" tag?

Thanks. I wasn't sure how to properly apply that.

>
>> + fsparam_string("fsdef", Opt_fsdefault),
>> fsparam_string("fsdefault", Opt_fsdefault),
>> fsparam_string("fsfloor", Opt_fsfloor),
>> fsparam_string("fshat", Opt_fshat),
> Would it be better to delete the "fsdefault" line?

If it hadn't slipped into the 5.1 release I would
say to remove it, but now it would be a regression.

>
> Also, should all of these be prefixed with "smack"? So:
>
> fsparam_string("smackfsdef", Opt_fsdefault),
> fsparam_string("smackfsfloor", Opt_fsfloor),
> fsparam_string("smackfshat", Opt_fshat),

No. smack_fs_parameters takes care of that.

>
> David

\
 
 \ /
  Last update: 2019-05-28 17:52    [W:0.083 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site