Messages in this thread | | | Subject | Re: [PATCH] Smack: Restore the smackfsdef mount option | From | Casey Schaufler <> | Date | Tue, 28 May 2019 08:51:24 -0700 |
| |
On 5/28/2019 5:23 AM, David Howells wrote: > Casey Schaufler <casey@schaufler-ca.com> wrote: > >> The change was made in commit c3300aaf95fb4 from Al Viro. > This should be in a "Fixes:" tag?
Thanks. I wasn't sure how to properly apply that.
> >> + fsparam_string("fsdef", Opt_fsdefault), >> fsparam_string("fsdefault", Opt_fsdefault), >> fsparam_string("fsfloor", Opt_fsfloor), >> fsparam_string("fshat", Opt_fshat), > Would it be better to delete the "fsdefault" line?
If it hadn't slipped into the 5.1 release I would say to remove it, but now it would be a regression.
> > Also, should all of these be prefixed with "smack"? So: > > fsparam_string("smackfsdef", Opt_fsdefault), > fsparam_string("smackfsfloor", Opt_fsfloor), > fsparam_string("smackfshat", Opt_fshat),
No. smack_fs_parameters takes care of that.
> > David
| |