lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Smack: Restore the smackfsdef mount option
Date
Casey Schaufler <casey@schaufler-ca.com> wrote:

> The change was made in commit c3300aaf95fb4 from Al Viro.

This should be in a "Fixes:" tag?

> + fsparam_string("fsdef", Opt_fsdefault),
> fsparam_string("fsdefault", Opt_fsdefault),
> fsparam_string("fsfloor", Opt_fsfloor),
> fsparam_string("fshat", Opt_fshat),

Would it be better to delete the "fsdefault" line?

Also, should all of these be prefixed with "smack"? So:

fsparam_string("smackfsdef", Opt_fsdefault),
fsparam_string("smackfsfloor", Opt_fsfloor),
fsparam_string("smackfshat", Opt_fshat),

David

\
 
 \ /
  Last update: 2019-05-28 14:23    [W:0.074 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site