Messages in this thread Patch in this message | | | From | Andy Lutomirski <> | Subject | [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export | Date | Thu, 2 May 2019 07:42:14 -0700 |
| |
The FPU is not a super-Linuxy internal detail, so remove the _GPL from its export. Without something like this patch, it's impossible for even highly license-respecting non-GPL modules to use the FPU, which seems silly to me. After all, the FPU is a CPU feature, not really a kernel feature at all.
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc:: Borislav Petkov <bp@suse.de> Cc: Rik van Riel <riel@surriel.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Nicolai Stange <nstange@suse.de> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Radim Krčmář <rkrcmar@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: x86@kernel.org Cc: stable@vger.kernel.org Fixes: 12209993e98c ("x86/fpu: Don't export __kernel_fpu_{begin,end}()") Signed-off-by: Andy Lutomirski <luto@kernel.org> ---
This fixes a genuine annoyance for ZFS on Linux. Regardless of what one may think about the people who distribute ZFS on Linux *binaries*, as far as I know, the source and the users who build it themselves are entirely respectful of everyone's license. I have no problem with EXPORT_SYMBOL_GPL() in general, but let's please avoid using it for things that aren't fundamentally Linux internals.
arch/x86/kernel/fpu/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c index 2e5003fef51a..8de5687a470d 100644 --- a/arch/x86/kernel/fpu/core.c +++ b/arch/x86/kernel/fpu/core.c @@ -127,14 +127,14 @@ void kernel_fpu_begin(void) preempt_disable(); __kernel_fpu_begin(); } -EXPORT_SYMBOL_GPL(kernel_fpu_begin); +EXPORT_SYMBOL(kernel_fpu_begin); void kernel_fpu_end(void) { __kernel_fpu_end(); preempt_enable(); } -EXPORT_SYMBOL_GPL(kernel_fpu_end); +EXPORT_SYMBOL(kernel_fpu_end); /* * Save the FPU state (mark it for reload if necessary): -- 2.21.0
| |