lkml.org 
[lkml]   [2019]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export
On Fri, 3 May 2019, Jiri Kosina wrote:

> > Please don't start this. We have everything _GPL that is used for FPU
> > related code and only a few functions are exported because KVM needs it.
>
> That's not completely true. There are a lot of static inlines out there,
> which basically made it possible for external modules to use FPU (in some
> way) when they had kernel_fpu_[begin|end]() available.

... any for many uses that's really the only thing that's needed.

kernel_fpu_beign();
asm volatile ("some SSE2/AVX/... math");
kernel_fpu_end();

No other bits of the FPU API, so there is no way of getting anything wrong
because of FPU intrinsic details really.

So I don't really see a problem with Andy's patch. If we want to annoy
external non-GPL modules as much as possible, sure, that's for a separate
discussion though (and I am sure many people would agree to that).
Proposal to get rid of EXPORT_SYMBOL in favor of EXPORT_SYMBOL_GPL would
be a good start I guess :)

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2019-05-04 09:27    [W:0.115 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site