Messages in this thread | | | Date | Thu, 21 Feb 2019 18:40:54 +0800 | From | kbuild test robot <> | Subject | Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters |
| |
Hi Nikolaus,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.0-rc4 next-20190220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Nikolaus-Voss/usb-typec-tps6598x-handle-block-writes-separately-with-plain-I2C-adapters/20190221-165456 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: i386-randconfig-a0-201907 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb/typec/tps6598x.c: In function 'tps6598x_block_write': >> drivers/usb/typec/tps6598x.c:132:2: warning: variable length array 'data' is used [-Wvla] u8 data[len + 1]; ^
vim +/data +132 drivers/usb/typec/tps6598x.c
128 129 static int tps6598x_block_write(struct tps6598x *tps, u8 reg, 130 void *val, size_t len) 131 { > 132 u8 data[len + 1]; 133 134 if (!tps->i2c_protocol) 135 return regmap_raw_write(tps->regmap, reg, val, len); 136 137 data[0] = len; 138 memcpy(&data[1], val, len); 139 140 return regmap_raw_write(tps->regmap, reg, data, sizeof(data)); 141 } 142
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |