lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters
    On Wed, 20 Feb 2019, Heikki Krogerus wrote:
    > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote:
    >> Commit 1a2f474d328f handles block _reads_ separately with plain-I2C
    >> adapters, but the problem described with regmap-i2c not handling
    >> SMBus block transfers (i.e. read and writes) correctly also exists
    >> with writes.
    >>
    >> As workaround, this patch adds a block write function the same way
    >> 1a2f474d328f adds a block read function.
    >>
    >> Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters")
    >> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
    >> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
    >
    > You are missing a "from" line with address that matches your SoB
    > address.

    That's because I currently cannot send patch mails from my company
    account as our MTA breaks diffs. You could add

    Signed-off-by: Nikolaus Voss <nv@vosn.de>

    Nikolaus

    \
     
     \ /
      Last update: 2019-02-20 14:39    [W:3.084 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site