Messages in this thread | | | Date | Wed, 20 Feb 2019 16:22:00 +0100 (CET) | From | Nikolaus Voss <> | Subject | Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters |
| |
On Wed, 20 Feb 2019, Greg Kroah-Hartman wrote: > On Wed, Feb 20, 2019 at 01:57:30PM +0100, Nikolaus Voss wrote: >> Commit 1a2f474d328f handles block _reads_ separately with plain-I2C >> adapters, but the problem described with regmap-i2c not handling >> SMBus block transfers (i.e. read and writes) correctly also exists >> with writes. >> >> As workaround, this patch adds a block write function the same way >> 1a2f474d328f adds a block read function. >> >> Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately with plain-I2C adapters") >> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers") >> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> >> --- > > As was pointed out, you have to have a From: that matches a > signed-off-by somewhere here. If your company email systems is horrid > and can not handle patches, then put the correct from: line as the first > line of the commit message as the documentation says and all will be > good. > > > >> v2: fix tps6598x_exec_cmd also >> --- >> drivers/usb/typec/tps6598x.c | 26 ++++++++++++++++++++------ >> 1 file changed, 20 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c >> index c84c8c189e90..c54b73fb2a2f 100644 >> --- a/drivers/usb/typec/tps6598x.c >> +++ b/drivers/usb/typec/tps6598x.c >> @@ -110,6 +110,20 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len) >> return 0; >> } >> >> +static int tps6598x_block_write(struct tps6598x *tps, u8 reg, >> + void *val, size_t len) >> +{ >> + u8 data[len + 1]; > > I thought the build system now warned when you did this :(
I must admit I'm developing on 4.19 stable series, so no warnings...
Nikolaus
| |