Messages in this thread | | | From | Christophe ROULLIER <> | Subject | Re: [PATCH 2/8] net: ethernet: stmmac: update to support all PHY config for stm32mp157c. | Date | Thu, 14 Feb 2019 15:00:48 +0000 |
| |
On 2/14/19 2:40 PM, Andrew Lunn wrote: > On Thu, Feb 14, 2019 at 07:45:57AM +0100, Christophe Roullier wrote: >> @@ -131,19 +185,19 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat) >> case PHY_INTERFACE_MODE_RGMII: >> val = SYSCFG_PMCR_ETH_SEL_RGMII; >> - if (dwmac->int_phyclk) >> + if (dwmac->eth_clk_sel_reg) >> val |= SYSCFG_PMCR_ETH_CLK_SEL; >> pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n"); >> break; > > Hi Christophe > > This code should handle all 4 PHY_INTERFACE_MODE_RGMII* values. > > Andrew >
ReReHi Andrew,
Sorry, I've misunderstood your question ;-)
And you spoke about :
case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID:
So in my setup I've only RGMII interface, so I've never tested 3 others interfaces (_ID, _RXID, _TXID).
So do I need to add cases in my driver ?
Thanks
Christophe
| |