Messages in this thread | | | From | Bjorn Helgaas <> | Subject | [PATCH 0/2] drm: replace magic nuumbers | Date | Thu, 7 Nov 2019 16:20:45 -0600 |
| |
From: Bjorn Helgaas <bhelgaas@google.com>
amdgpu and radeon do a bit of mucking with the PCIe Link Control 2 register, some of it using hard-coded magic numbers. The idea here is to replace those with #defines.
I haven't signed off on these because the first one actually changes the bits involved because the existing code looks like it might have a typo. But I have no way to know for sure.
I don't intend the Target Link Speed patch to change anything, so it should be straightforward to review.
Bjorn Helgaas (2): drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions drm: replace Target Link Speed magic numbers with PCI_EXP_LNKCTL2 definitions
drivers/gpu/drm/amd/amdgpu/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/amd/amdgpu/si.c | 18 +++++++++++------- drivers/gpu/drm/radeon/cik.c | 22 ++++++++++++++-------- drivers/gpu/drm/radeon/si.c | 22 ++++++++++++++-------- include/uapi/linux/pci_regs.h | 2 ++ 5 files changed, 55 insertions(+), 31 deletions(-)
-- 2.24.0.rc1.363.gb1bccd3e3d-goog
| |