Messages in this thread | | | From | Ilia Mirkin <> | Date | Thu, 7 Nov 2019 17:30:00 -0500 | Subject | Re: [PATCH 1/2] drm: replace Compliance/Margin magic numbers with PCI_EXP_LNKCTL2 definitions |
| |
On Thu, Nov 7, 2019 at 5:21 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 29d6e93fd15e..03446be8a7be 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -673,6 +673,8 @@ > #define PCI_EXP_LNKCTL2_TLS_8_0GT 0x0003 /* Supported Speed 8GT/s */ > #define PCI_EXP_LNKCTL2_TLS_16_0GT 0x0004 /* Supported Speed 16GT/s */ > #define PCI_EXP_LNKCTL2_TLS_32_0GT 0x0005 /* Supported Speed 32GT/s */ > +#define PCI_EXP_LNKCTL2_ENTER_COMP 0x0010 /* Enter Compliance */ > +#define PCI_EXP_LNKCTL2_TX_MARGIN 0x0380 /* Enter Compliance */
Without commenting on the meat of the patch, this comment should probably read "Transmit Margin" or something along those lines?
-ilia
| |