Messages in this thread | | | From | John Stultz <> | Date | Mon, 28 Oct 2019 13:03:05 -0700 | Subject | Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module |
| |
On Mon, Oct 28, 2019 at 12:12 PM <sspatil@google.com> wrote: > On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > > --- a/kernel/dma/contiguous.c > > +++ b/kernel/dma/contiguous.c > > @@ -31,6 +31,7 @@ > > #endif > > > > struct cma *dma_contiguous_default_area; > > +EXPORT_SYMBOL(dma_contiguous_default_area); > > I didn't need to do this for the (out-of-tree) ion cma heap [1]. > Any reason why you had to?
Its likely due to the changes I made in the separate non-default-CMA-region patch set. Earlier I had gotten away with just your change, but in testing before I sent this series, I hit the build error and quickly added the export before sending.
I'll revise and respin this. Mostly just wanting to get initial feedback on the dmabuf-heaps-as-modules bit, so I didn't take as much care as I should have with the exports here.
thanks -john
| |