Messages in this thread | | | From | John Stultz <> | Date | Mon, 28 Oct 2019 11:39:03 -0700 | Subject | Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module |
| |
On Mon, Oct 28, 2019 at 12:46 AM Christoph Hellwig <hch@infradead.org> wrote: > > On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > > struct cma *dma_contiguous_default_area; > > +EXPORT_SYMBOL(dma_contiguous_default_area); > > Please CC the dma maintainer. And no, you have no business using this.
Sure thing. And I'll look again to see why I was needing to pull that one in to get it to build.
> Even if you did, internals like this should always be EXPORT_SYMBOL_GPL.
Certainly! My mistake here!
Thanks for the feedback! -john
| |