Messages in this thread Patch in this message | | | Date | Mon, 28 Oct 2019 12:12:31 -0700 | From | sspatil@google ... | Subject | Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module |
| |
On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote: > From: Sandeep Patil <sspatil@google.com> > > Export cma_get_name, cma_alloc, cma_release, cma_for_each_area > and dma_contiguous_default_area so that we can use these from > the dmabuf cma heap when it is built as module. > > Cc: Laura Abbott <labbott@redhat.com> > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Liam Mark <lmark@codeaurora.org> > Cc: Pratik Patel <pratikp@codeaurora.org> > Cc: Brian Starkey <Brian.Starkey@arm.com> > Cc: Andrew F. Davis <afd@ti.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Yue Hu <huyue2@yulong.com> > Cc: Mike Rapoport <rppt@linux.ibm.com> > Cc: Chenbo Feng <fengc@google.com> > Cc: Alistair Strachan <astrachan@google.com> > Cc: Sandeep Patil <sspatil@google.com> > Cc: Hridya Valsaraju <hridya@google.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Sandeep Patil <sspatil@google.com> > [jstultz: Rewrote commit message, added > dma_contiguous_default_area to the set of exported symbols] > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > kernel/dma/contiguous.c | 1 + > mm/cma.c | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index 69cfb4345388..ff6cba63ea6f 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -31,6 +31,7 @@ > #endif > > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area);
I didn't need to do this for the (out-of-tree) ion cma heap [1]. Any reason why you had to?
Other than that, thanks for doing this John.
Acked-by: Sandeep Patil <sspatil@google.com>
- ssp
1] https://android-review.googlesource.com/c/kernel/common/+/1121591
| |