lkml.org 
[lkml]   [2018]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v3 07/16] thermal: tsens: Pass register offsets as private data
On Wed 12 Sep 02:52 PDT 2018, Amit Kucheria wrote:
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 9a8e8f7b4ae1..f1ec9bbe4717 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -144,6 +144,9 @@ static int tsens_probe(struct platform_device *pdev)
> else
> tmdev->sensor[i].hw_id = i;
> }
> + for (i = 0; i < REG_ARRAY_SIZE; i++) {
> + tmdev->reg_offsets[i] = data->reg_offsets[i];
> + }

Unnecessary {}

>
> if (!tmdev->ops || !tmdev->ops->init || !tmdev->ops->get_temp)
> return -EINVAL;
> diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> index b9c4bcf255fa..7b7feee5dc46 100644
> --- a/drivers/thermal/qcom/tsens.h
> +++ b/drivers/thermal/qcom/tsens.h
> @@ -48,15 +48,23 @@ struct tsens_ops {
> int (*get_trend)(struct tsens_device *, int, enum thermal_trend *);
> };
>
> +enum reg_list {
> + SROT_CTRL_OFFSET,
> +
> + REG_ARRAY_SIZE,
> +};
> +
> /**
> * struct tsens_data - tsens instance specific data
> * @num_sensors: Max number of sensors supported by platform
> * @ops: operations the tsens instance supports
> * @hw_ids: Subset of sensors ids supported by platform, if not the first n
> + * @reg_offsets: Register offsets for commonly used registers

Order doesn't match struct.

> */
> struct tsens_data {
> const u32 num_sensors;
> const struct tsens_ops *ops;
> + const u16 reg_offsets[REG_ARRAY_SIZE];
> unsigned int *hw_ids;
> };

Except of that you have my:

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

\
 
 \ /
  Last update: 2018-09-18 21:31    [W:0.283 / U:20.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site